Skip to content

MAINT: update linkchecker to use lychee (weekly) #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Aug 5, 2025

This PR converts the link checker action to use lychee on a weekly schedule.

@mmcky mmcky requested a review from Copilot August 5, 2025 03:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the link checking workflow by replacing the custom Jupyter Book linkcheck with the lychee tool and changes the execution schedule from pull request triggers to a weekly schedule. This improves efficiency by using a dedicated link checking tool and reduces CI overhead by running checks periodically rather than on every PR.

Key changes:

  • Replaces manual Jupyter Book linkcheck process with lychee link checker
  • Changes trigger from pull requests to weekly scheduled runs (Sundays at 23:00 UTC)
  • Adds automatic issue creation when broken links are detected

@jstac
Copy link
Contributor

jstac commented Aug 5, 2025

How did you find this @mmcky ? Did the AI do a good job?

@mmcky
Copy link
Contributor Author

mmcky commented Aug 5, 2025

How did you find this @mmcky ? Did the AI do a good job?

I have been triggering Google Copilot just to see what it would say in comments to all recent PRs. I find it typically provides a good suggestion or two, it also summarises the PR well.

@jstac this one was the most interesting so far #217

@jstac
Copy link
Contributor

jstac commented Aug 5, 2025

Ah, I see, copilot is just summarizing. I thought it had written all that code :-)

Nice work @mmcky :-)

@mmcky
Copy link
Contributor Author

mmcky commented Aug 5, 2025

Ah, I see, copilot is just summarizing. I thought it had written all that code :-)

That would be nice :-) !

@mmcky mmcky merged commit 51477f3 into main Aug 5, 2025
5 checks passed
@mmcky mmcky deleted the upd-linkchecker branch August 5, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants